<html>
<head><meta charset="utf-8"><title>review guide pr · t-compiler · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/index.html">t-compiler</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/review.20guide.20pr.html">review guide pr</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="197581009"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/review%20guide%20pr/near/197581009" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mark-i-m <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/review.20guide.20pr.html#197581009">(May 14 2020 at 16:26)</a>:</h4>
<p>Hi, could someone take a look at <a href="https://github.com/rust-lang/rustc-dev-guide/pull/697">https://github.com/rust-lang/rustc-dev-guide/pull/697</a></p>



<a name="197581067"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/review%20guide%20pr/near/197581067" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mark-i-m <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/review.20guide.20pr.html#197581067">(May 14 2020 at 16:27)</a>:</h4>
<p>I think it is right, but I don't feel confident about it</p>



<a name="197590382"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/review%20guide%20pr/near/197590382" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/review.20guide.20pr.html#197590382">(May 14 2020 at 17:32)</a>:</h4>
<p><span class="user-mention" data-user-id="198054">@mark-i-m</span> left some comments</p>



<a name="197590419"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/review%20guide%20pr/near/197590419" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/review.20guide.20pr.html#197590419">(May 14 2020 at 17:33)</a>:</h4>
<p>I hadn't seen that before, sorry</p>



<a name="197590517"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/review%20guide%20pr/near/197590517" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/review.20guide.20pr.html#197590517">(May 14 2020 at 17:33)</a>:</h4>
<p>currently teetering on my ability to keep up with GH notifications and reviews, partially underwater, but hoping not to drown =) <span aria-label="water drop" class="emoji emoji-1f4a7" role="img" title="water drop">:water_drop:</span></p>



<a name="197590611"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/review%20guide%20pr/near/197590611" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/review.20guide.20pr.html#197590611">(May 14 2020 at 17:34)</a>:</h4>
<p>we should hook up the bot (whichever one it is) that makes <code>r?</code> work...</p>



<a name="197591734"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/review%20guide%20pr/near/197591734" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/review.20guide.20pr.html#197591734">(May 14 2020 at 17:44)</a>:</h4>
<p><span class="user-mention silent" data-user-id="116009">nikomatsakis</span> <a href="#narrow/stream/131828-t-compiler/topic/review.20guide.20pr/near/197590611">said</a>:</p>
<blockquote>
<p>we should hook up the bot (whichever one it is) that makes <code>r?</code> work...</p>
</blockquote>
<p>(I think that is still <code>@high-five</code> since <a href="https://github.com/rust-lang/triagebot/issues/433">triagebot#433</a> didn't land yet)</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>